Refuse to handle incoming request after server is stopped#2363
Merged
hueniverse merged 1 commit intohapijs:masterfrom Feb 8, 2015
Merged
Refuse to handle incoming request after server is stopped#2363hueniverse merged 1 commit intohapijs:masterfrom
hueniverse merged 1 commit intohapijs:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Why not just check _started?
Contributor
Author
There was a problem hiding this comment.
Because _started is always false when using inject().
Contributor
There was a problem hiding this comment.
Not if you also check for req.connection.
Contributor
Author
|
I'm sure there are other ways to fix this, but this seemed quite simple. Another approach could be to remove the |
This was referenced Jan 28, 2015
hueniverse
added
bug
hueniverse
pushed a commit
that referenced
this pull request
Feb 8, 2015
Refuse to handle incoming request after server is stopped
Merged
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in nodejs/node-v0.x-archive#9066,
nodecan continue to emitrequestevents on closed http servers. This patch works around this by checking if the server is stopping before responding to incoming requests.