Resolve undefined environment variables to the empty string in the cli.#2024
Merged
hueniverse merged 1 commit intohapijs:masterfrom Oct 11, 2014
Merged
Resolve undefined environment variables to the empty string in the cli.#2024hueniverse merged 1 commit intohapijs:masterfrom
hueniverse merged 1 commit intohapijs:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
New line after function declaration per style guide
Contributor
Author
There was a problem hiding this comment.
Oops, sorry about that. Fixed.
Have you considered using a tool like jscs to automate some of this?
jagoda
force-pushed
the
fix-default-port
branch
from
593c019 to
830c02b
Compare
hueniverse
pushed a commit
that referenced
this pull request
Oct 11, 2014
Resolve undefined environment variables to the empty string in the cli.
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a manifest that references undefined environment variables for port values, the pack fails to start because
undefinedis not a valid port parameter for aServer. This change causes the cli to treat undefined environment variables as the empty string. In the case where a port value is parsed, this will cause the server to use an ephemeral port.