Skip to content

show route method in error message#2002

Merged
hueniverse merged 1 commit intohapijs:masterfrom
chulkilee:route-error-mesg
Oct 5, 2014
Merged

show route method in error message#2002
hueniverse merged 1 commit intohapijs:masterfrom
chulkilee:route-error-mesg

Conversation

@chulkilee
Copy link
Copy Markdown
Contributor

Showing only path is not enough to identify the exact route configuration when there are multiple methods for the same path.

@hueniverse
Copy link
Copy Markdown
Contributor

If you are going to make this change, be consistent and make it across all the other assertions...

@hueniverse hueniverse added the feature New functionality or improvement label Oct 3, 2014
@hueniverse hueniverse self-assigned this Oct 3, 2014
@chulkilee
Copy link
Copy Markdown
Contributor Author

That makes sense. I amended the commit to add options.method when adding options.path.

@hueniverse hueniverse added this to the 6.11.1 milestone Oct 5, 2014
hueniverse pushed a commit that referenced this pull request Oct 5, 2014
show route method in error message
@hueniverse hueniverse merged commit 3d0b093 into hapijs:master Oct 5, 2014
@lock
Copy link
Copy Markdown

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants