Test for both formats of Content-Encoding header#1076
Merged
hueniverse merged 1 commit intohapijs:masterfrom Sep 30, 2013
Merged
Test for both formats of Content-Encoding header#1076hueniverse merged 1 commit intohapijs:masterfrom
hueniverse merged 1 commit intohapijs:masterfrom
Conversation
hueniverse
pushed a commit
that referenced
this pull request
Sep 30, 2013
Test for both formats of Content-Encoding header
jmonster
pushed a commit
to jmonster/hapi
that referenced
this pull request
Feb 10, 2014
Test for both formats of Content-Encoding header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to some inconsistencies in how headers are formatted through the code, I added an extra check for 'Content-Encoding' as well as 'content-encoding' when determining if the response should be compressed.
This came up due to wanting to manually gzip a response in a handler, and manually setting the 'Content-Encoding' header. If I used the proper format, the existing code would compress my already compressed response.
I feel this is a band-aid to a bigger issue, that is inconsistent header formatting in what is being checked for and what is being added as headers.
I also added tests for GET requests in the gzip integration test, as well was removed a duplicate test near the end.