Allow omitting Domain attribute in SetCookie per RFC 6265#3316
Open
QDenka wants to merge 1 commit intoguzzle:7.10from
Open
Allow omitting Domain attribute in SetCookie per RFC 6265#3316QDenka wants to merge 1 commit intoguzzle:7.10from
QDenka wants to merge 1 commit intoguzzle:7.10from
Conversation
Per RFC 6265 Section 4.1.2.3, when the Domain attribute is omitted from a Set-Cookie header, the cookie becomes a host-only cookie that is returned only to the origin server. This is distinct from explicitly setting the Domain to the origin, which also allows subdomains. Previously, SetCookie::validate() rejected cookies with a null Domain, making it impossible to store host-only cookies in the CookieJar. This change allows null Domain in validate() while still rejecting empty string domains. The matchesDomain() method already handles null domains correctly. Fixes guzzle#3315
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per RFC 6265 Section 4.1.2.3, when the Domain attribute is omitted from a Set-Cookie header, the cookie becomes a host-only cookie returned only to the origin server. This is distinct from explicitly setting the Domain to the origin, which also allows subdomains.
Problem
Currently,
SetCookie::validate()rejects cookies with anullDomain, throwing:This makes it impossible to store host-only cookies in the
CookieJarwhen creating cookies manually (without going throughextractCookies()).Solution
Allow
nullDomain invalidate()while still rejecting empty string ('') domains. ThematchesDomain()method already handlesnulldomains correctly (returnstrue).Changes
src/Cookie/SetCookie.php: Updatedvalidate()to allownulldomain (host-only cookie)tests/Cookie/SetCookieTest.php: Added test case for null domain validationtests/Cookie/CookieJarTest.php: Added test verifying CookieJar accepts cookies without DomainFixes #3315