Open
Conversation
snipe
added
the
Merge Ready - on Hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades to Livewire v4 (v4.1.0 specifically).
A couple notes:
snipeit.jshas been updated so assets need to be re-built.php artisan optimize:clearto clear out the cache.csp_safetofalsebecause we are using some global references. Search forcsp_safeon this page for more info.php artisan make:livewireis a single file component but I set the config to use class-based like weare currently using. I'd like to explore multiple file components though.
Upgrade guide for reference.
I expect a
composer.lockmerge conflict between this and #18492 and will update after one is merged.