Open
Conversation
Member
|
IIRC, we specifically chose not to make this a dev dependency though. |
Collaborator
Author
|
@snipe #14899 moved it back to a regular dependency because it is used in some controllers. I tracked down the packages That screenshot is for the entire project and it looks like we're not calling the facade elsewhere. The actual service class, isn't used directly either: I can move it back to a dev dependency if you prefer though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades Laravel Debugbar to version 4.
There isn't a lot that changes for us in this version but it doesn't hurt to keep dependencies up to date.
Keeping #14899 in mind, I moved the package back to being a
devdependency and added some logic (via a trait) to disable Debugbar if it is installed.I also pulled in the new configuration file and updated it to match the settings we had for v3.
Note:
symfony/http-foundationwas updated (v7.3.7 => v7.4.4) and I had to update a couple tests (UTF-8=>utf-8).