Fix ExecutableNormalizedField to respect GraphqlFieldVisibility #4204
+88
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ExecutableNormalizedField.forEachFieldDefinition()andgetOneFieldDefinition()calltype.getField(fieldName)directly, bypassing the schema's configuredGraphqlFieldVisibility.This is inconsistent with other parts of graphql-java (validation, execution) that respect field visibility, and causes issues when:
Reproduction
GraphqlFieldVisibilitythat provides virtual/placeholder fieldsDataFetchingEnvironment.getSelectionSet().getFields()in a DataFetcherExecutableNormalizedField.forEachFieldDefinition()callstype.getField()directlySolution
Change the field lookup to use the schema's field visibility: