-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add normalized document provider to allow caching of normalized documents #4048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add normalized document provider to allow caching of normalized documents #4048
Conversation
da290e2 to
bdc9f7c
Compare
86bb621 to
fbb6e8b
Compare
fbb6e8b to
16b0262
Compare
16b0262 to
8e2e760
Compare
| this.executionInput = builder.executionInput; | ||
| this.dataLoaderDispatcherStrategy = builder.dataLoaderDispatcherStrategy; | ||
| this.queryTree = FpKit.interThreadMemoize(() -> ExecutableNormalizedOperationFactory.createExecutableNormalizedOperation(graphQLSchema, operationDefinition, fragmentsByName, coercedVariables)); | ||
| this.queryTree = FpKit.interThreadMemoize(() -> this. createGraphQLNormalizedOperation().join()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nit: there's a space after this.
|
Hello, this pull request has been inactive for 60 days, so we're marking it as stale. If you would like to continue working on this pull request, please make an update within the next 30 days, or we'll close the pull request. |
|
Hello, as this pull request has been inactive for 90 days, we're closing this pull request. We always welcome contributions, and if you would like to continue, please open a new pull request. |
This PR enables:
NormalizedDocumentimplementation behind an experimental API configuration.There a few things that could be improved, but would require larger more broader changes, including: