Draft
Conversation
SemyonSinchenko
added
scala
pyspark-classic
james-willis
reviewed
Feb 4, 2026
core/src/test/scala/org/graphframes/lib/AggregateNeighborsSuite.scala
Outdated
Show resolved
Hide resolved
james-willis
reviewed
Feb 4, 2026
core/src/test/scala/org/graphframes/lib/AggregateNeighborsSuite.scala
Outdated
Show resolved
Hide resolved
james-willis
reviewed
Feb 4, 2026
core/src/main/scala/org/graphframes/lib/AggregateNeighbors.scala
Outdated
Show resolved
Hide resolved
james-willis
reviewed
Feb 4, 2026
james-willis
requested changes
Feb 4, 2026
core/src/main/scala/org/graphframes/lib/AggregateNeighbors.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/graphframes/lib/AggregateNeighbors.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/graphframes/lib/AggregateNeighbors.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/graphframes/lib/AggregateNeighbors.scala
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Hi @james-willis ! I addressed most of your comments. For some I left my answers. It looks like we are close to a final version. Could be nice if you can take another look, so I can work on bindings and docs. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
- Coverage 84.90% 83.94% -0.96%
==========================================
Files 68 69 +1
Lines 3444 3668 +224
Branches 431 428 -3
==========================================
+ Hits 2924 3079 +155
- Misses 520 589 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I will work on tests, bindings and docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
New API as described in #785
Why are the changes needed?
Close #785