chore: add scalafmt and re-format all the code#507
chore: add scalafmt and re-format all the code#507rjurney merged 3 commits intographframes:masterfrom
Conversation
|
@rjurney @bjornjorgensen Hello! Can you review it, please? It may look huge but there are no changes in the code, only formatting of the code. Thanks! |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
==========================================
- Coverage 91.43% 90.73% -0.70%
==========================================
Files 18 18
Lines 829 896 +67
Branches 52 100 +48
==========================================
+ Hits 758 813 +55
- Misses 71 83 +12 ☔ View full report in Codecov by Sentry. |
|
@SemyonSinchenko oh, one thing - are these the same settings as Spark? The plan is to eventually merge GraphFrames into Spark main, so consistency with their settings would be nice. |
I copied the whole |
|
@rjurney Can we merge this one? It allows to apply |
|
@rjurney are there anything wrong with this PR? |
|
Merging... @bjornjorgensen nothing wrong :) |
4 participants
This PR closes #500
Changes:
.scalafmt.confis added with content exactly like in the Apache Spark Projectscalafmtplugin is added to the plugins.metalsis added to the.gitignoreP.S. Metals is the most popular LSP for Scala that is used in VSCode, Vim / NeoVim, Emacs, Sublime, etc. I think it is nice to have it in
.gitignorebecause it simplify the working with git and reduce a chance of accidentally pushing something not related to the project itself.P.P.S. All the changes in the scala code is related to formatting only! There are no actual changes of the logic.