Re-add note about Python 3 support#151
Merged
thunterdb merged 1 commit intographframes:masterfrom Jan 4, 2017
Merged
Conversation
Current coverage is 87.18% (diff: 100%)@@ master #151 diff @@
==========================================
Files 18 18
Lines 765 765
Methods 687 687
Messages 0 0
Branches 68 68
==========================================
Hits 667 667
Misses 98 98
Partials 0 0
|
Contributor
|
@nchammas I think we cannot promise python 3 support without testing it in Travis CI. Do you have time to update the Travis file? |
Contributor
Author
|
Good point. Will do. |
Contributor
Author
|
@mengxr - It looks like tests are already being run against Python 3. |
jkbradley
pushed a commit
that referenced
this pull request
Jan 17, 2017
#151 * supported versions * remove patch version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I talked @mengxr out of adding this in the first time around here in this PR, but it looks like GrapheFrames works fine with Python 3, and I've been using it as such for many weeks now.