Skip to content

Comments

[85] python 3 support#135

Merged
mengxr merged 17 commits intographframes:masterfrom
thunterdb:1611-python3
Nov 11, 2016
Merged

[85] python 3 support#135
mengxr merged 17 commits intographframes:masterfrom
thunterdb:1611-python3

Conversation

@thunterdb
Copy link
Contributor

No description provided.

@thunterdb thunterdb changed the title Tentative python 3 support python 3 support Nov 10, 2016
.travis.yml Outdated
addons:
apt:
packages:
- python3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that Python3 should be preinstalled on trusty image: https://docs.travis-ci.com/user/trusty-ci-environment/#Python. Do we need it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I have not tried to remove these flags since moving to trusty.

matrix:
exclude:
- scala: 2.10.5 # Spark 2.0.0 pre-built with Scala 2.11 in the tgz download
env: SPARK_VERSION=2.0.1 SPARK_BUILD="spark-2.0.1-bin-hadoop2.7" SPARK_BUILD_URL="http://d3kbcqa49mib13.cloudfront.net/spark-2.0.1-bin-hadoop2.7.tgz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it simpler if we don't list scala as the main language and let the test line be sbt -Dscala.version=2.10.6, e.g.?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, shall we also bump scala version from 2.10.5 to 2.10.6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to try it out.


install:
- pip install --user -r ./python/requirements.txt
- pip3 install --user -r ./python/requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might use pyenv to switch python version first and make this line the same for py2 and py3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we keep it this way for now. It just takes a few seconds and it is simpler to install both.

- oraclejdk7 # openJDK crashes sometimes
sudo: false

sudo: required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we no longer need to install pip, does it mean we don't need sudo either?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do. trusty is beta, and fails (jvm package not properly installed)

@mengxr mengxr added the lgtm label Nov 11, 2016
@mengxr mengxr merged commit 94c9680 into graphframes:master Nov 11, 2016
@nchammas nchammas mentioned this pull request Nov 11, 2016
@nchammas
Copy link
Contributor

I suppose this addresses #85.

In the future, it would be good to include "Fixes #85" in the PR description so that when the PR gets merged in, the associated issue gets automatically closed and people are notified that their issue is fixed.

@thunterdb thunterdb changed the title python 3 support [85] python 3 support Nov 11, 2016
@thunterdb
Copy link
Contributor Author

That's a great suggestion. Yes, we should tag the ticket in the title.

On Fri, Nov 11, 2016 at 8:50 AM, Nicholas Chammas [email protected]
wrote:

I suppose this addresses #85
#85.

In the future, it would be good to include "Fixes #85
#85" in the PR
description so that when the PR gets merged in, the associated issue gets
automatically closed and people are notified that their issue is fixed.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#135 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHPjAYPSvblAgxIImYs_Cbt53x5gkVanks5q9JzMgaJpZM4KvDUk
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants