Skip to content

Commit d96e8a3

Browse files
chore: testing against both java-11 and java-17 (#525)
* Testing against both java-11 and java-17 * Fix 11-17 migration based on oracle's guide
1 parent 0f52f76 commit d96e8a3

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

.github/workflows/scala-ci.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,16 @@ jobs:
88
include:
99
- spark-version: 3.5.4
1010
scala-version: 2.13.8
11+
java-version: 11
12+
- spark-version: 3.5.4
13+
scala-version: 2.13.8
14+
java-version: 17
15+
- spark-version: 3.5.4
16+
scala-version: 2.12.18
17+
java-version: 11
1118
- spark-version: 3.5.4
1219
scala-version: 2.12.18
20+
java-version: 17
1321
runs-on: ubuntu-22.04
1422
env:
1523
# fixing this error after tests success: sbt.ForkMain failed with exit code 134
@@ -21,12 +29,12 @@ jobs:
2129
- uses: actions/setup-java@v4
2230
with:
2331
distribution: "zulu"
24-
java-version: "11"
32+
java-version: "${{ matrix.java-version }}"
2533
- uses: actions/cache@v4
2634
with:
2735
path: |
2836
~/.ivy2/cache
29-
key: sbt-ivy-cache-spark-${{ matrix.spark-version}}-scala-${{ matrix.scala-version }}
37+
key: sbt-ivy-cache-spark-${{ matrix.spark-version}}-scala-${{ matrix.scala-version }}-java-${{ matrix.java-version }}
3038
- name: Check scalafmt
3139
run: build/sbt root/scalafmtCheckAll
3240
- name: Build and Test

build.sbt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,10 @@ lazy val root = (project in file("."))
5757
"-XX:ReservedCodeCacheSize=384m",
5858
"-XX:MaxMetaspaceSize=384m",
5959
"--add-opens=java.base/sun.nio.ch=ALL-UNNAMED",
60-
"--add-opens=java.base/java.lang=ALL-UNNAMED"
60+
"--add-opens=java.base/java.lang=ALL-UNNAMED",
61+
"--add-opens=java.base/java.nio=ALL-UNNAMED",
62+
"--add-opens=java.base/java.lang.invoke=ALL-UNNAMED",
63+
"--add-opens=java.base/java.util=ALL-UNNAMED",
6164
),
6265

6366
// Global settings

0 commit comments

Comments
 (0)