Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

Add exception handlers for Cancelled and StopIteration in bidi.BackgroundConsumer#620

Closed
dhendry wants to merge 2 commits intogoogleapis:mainfrom
dhendry:main
Closed

Add exception handlers for Cancelled and StopIteration in bidi.BackgroundConsumer#620
dhendry wants to merge 2 commits intogoogleapis:mainfrom
dhendry:main

Conversation

@dhendry
Copy link
Copy Markdown

@dhendry dhendry commented Feb 21, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes googleapis/google-cloud-python#15057 🦕

@dhendry dhendry requested a review from a team as a code owner February 21, 2024 20:55
@dhendry dhendry requested a review from a team February 21, 2024 20:55
@google-cla
Copy link
Copy Markdown

google-cla bot commented Feb 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vchudnov-g
Copy link
Copy Markdown
Contributor

Thanks for reporting the bugs and crafting this PR! We'll review these shortly.

@parthea
Copy link
Copy Markdown
Contributor

parthea commented Oct 21, 2024

Closing as stale

@parthea parthea closed this Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poor termination handling in bidi.BackgroundConsumer resulting in error logs

4 participants