feat(tools/cloudsqlpg): Add remaining vector assist tools for Cloud SQL Postgres#3203
Open
pavankrishna13 wants to merge 3 commits into
Open
feat(tools/cloudsqlpg): Add remaining vector assist tools for Cloud SQL Postgres#3203pavankrishna13 wants to merge 3 commits into
pavankrishna13 wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces four new tools for the Cloud SQL for PostgreSQL vector assist suite: list_specs, get_spec, delete_spec, and improve_query_recall. The changes include the implementation of these tools in Go, corresponding unit and integration tests, and comprehensive documentation. Feedback was provided regarding adherence to the repository style guide for documentation titles and tool naming conventions. Additionally, several instances of unused debug code and leftover queries in the improve_query_recall tool were identified for removal to maintain code quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds 4 new mcp tools for Cloud SQL Postgres source related to the vector assist postgres extension.
Tool Set :
vectorassistDescription : Use these skills to set up, manage, and optimize production-ready vector workloads by simply expressing your intent and performance requirements. This toolset covers the complete lifecycle, allowing you to create, view, modify, delete, and troubleshoot vector specifications.
Tools
improve_query_recalllist_specsget_specdelete_specManual Testing
Workflows covered by these tools
1. Improve Query Recall
Prompt : My search results aren't interesting and not relevant. Improve the vector search results for 'cymbal_products' table on vector column 'product_description_embeddings' having an index 'cymbal_products_product_description_embeddings_idx'
Expected tools to be used in the CUJ : improve-query-recall -> execute-sql
2. List Specs
Prompt : List all the vector specs for the table ‘cymbal_products’ and column ‘product_description’
Expected tools to be used in the CUJ : list-specs
3. Get Spec
Prompt : Get the complete the details about the vector spec 'spec_cymbal_products_1'
Expected tools to be used in the CUJ : get-spec
4. Delete Spec
Prompt : Delete the vector specification 'spec_cymbal_products_1'
Expected tools to be used in the CUJ : delete-spec
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #<issue_number_goes_here>