test(dlp): ensure GOOGLE_CLOUD_TESTS_IN_VPCSC is down cast for env variables#9274
Merged
busunkim96 merged 7 commits intogoogleapis:masterfrom Sep 24, 2019
Merged
test(dlp): ensure GOOGLE_CLOUD_TESTS_IN_VPCSC is down cast for env variables#9274busunkim96 merged 7 commits intogoogleapis:masterfrom
busunkim96 merged 7 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Tests currently fail outside of git due to minor differences in environment variable casing. test(dlp): ensure GOOGLE_CLOUD_TESTS_IN_VPCSC is down cast for env variable closes bug reported by siddinesh@
maximus12793
changed the title
…riable Tests currently fail outside of git due to minor differences in environment variable casing. Closes bug reported by siddinesh@
maximus12793
force-pushed
the
dlp_vpc_fix
branch
from
ff2c98e to
3e25041
Compare
…riable Tests currently fail outside of git due to minor differences in environment variable casing. Closes bug reported by siddinesh@
…riable Tests currently fail outside of git due to minor differences in environment variable casing. Closes bug reported by siddinesh@
maximus12793
changed the title
…riable Tests currently fail outside of git due to minor differences in environment variable casing. Closes bug reported by siddinesh@
…riable Tests currently fail outside of git due to minor differences in environment variable casing. Closes bug reported by siddines
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
…riables (#9274) Tests currently fail outside of git due to minor differences in environment variable casing. closes bug reported by siddinesh@
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug reported by siddinesh@, in which
Trueis passed rather thantrue. Causes Kokoro tests to break outside of git. This will ensure GOOGLE_CLOUD_TESTS_IN_VPCSC is always tested againsttrueas is the expected behavior.