Skip to content

Revert "api_core: Make PageIterator.item_to_value public. (#4702)"#4731

Merged
theacodes merged 2 commits intomasterfrom
revert-4702
Jan 11, 2018
Merged

Revert "api_core: Make PageIterator.item_to_value public. (#4702)"#4731
theacodes merged 2 commits intomasterfrom
revert-4702

Conversation

@theacodes
Copy link
Copy Markdown
Contributor

@theacodes theacodes commented Jan 10, 2018

This reverts commit 813a27e.

This is done to prevent a release-the-world scenario in order to release bigquery, spanner, and datastore. It will be re-reverted before the next minor release of api_core.

@theacodes theacodes requested a review from dhermes January 10, 2018 22:48
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2018
@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Jan 10, 2018

@jonparrott This is just a straight git revert. You also need to update spanner/google/cloud/spanner_v1/client.py and spanner/google/cloud/spanner_v1/instance.py:

$ git log -1 --pretty=%H
d2ff0b9a68b55dff09b905736df7ddaaf722ce95
$ git grep -l '\.item_to_value'
api_core/google/api_core/page_iterator.py
api_core/tests/unit/test_page_iterator.py
bigquery/tests/unit/test_table.py
datastore/google/cloud/datastore/query.py
spanner/google/cloud/spanner_v1/client.py
spanner/google/cloud/spanner_v1/instance.py

@theacodes
Copy link
Copy Markdown
Contributor Author

theacodes commented Jan 10, 2018

@dhermes good call.

@theacodes theacodes mentioned this pull request Jan 10, 2018
Merged
@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Jan 10, 2018

LGTM

@theacodes theacodes merged commit b0dc7bc into master Jan 11, 2018
@theacodes theacodes deleted the revert-4702 branch January 11, 2018 00:54
theacodes pushed a commit that referenced this pull request Jan 11, 2018
Revert "Revert "api_core: Make PageIterator.item_to_value public. (#4702
19c9d96 
)" (#4731)"

This reverts commit b0dc7bc.
@theacodes theacodes mentioned this pull request Jan 11, 2018
Merged
dhermes pushed a commit that referenced this pull request Jan 12, 2018
@dhermes
Revert "Revert "api_core: Make PageIterator.item_to_value public. (#4702
ba33494 
)" (#4731)"

This reverts commit b0dc7bc.
theacodes pushed a commit that referenced this pull request Feb 26, 2018
Revert "Revert "api_core: Make PageIterator.item_to_value public. (#4702
506e014 
)" (#4731)"

This reverts commit b0dc7bc.
parthea pushed a commit that referenced this pull request Nov 24, 2025
Revert "api_core: Make PageIterator.item_to_value public. (#4702)" (#…
88c8a4b 
…4731)
parthea pushed a commit that referenced this pull request Nov 24, 2025
Revert "api_core: Make PageIterator.item_to_value public. (#4702)" (#…
971489e 
…4731)
parthea pushed a commit that referenced this pull request Mar 9, 2026
Revert "api_core: Make PageIterator.item_to_value public. (#4702)" (#…
54aa1a6 
…4731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhermes dhermes Awaiting requested review from dhermes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theacodes @dhermes @googlebot