Skip to content

Remove orphaned _fixtures.py.#2362

Merged
daspecster merged 2 commits intogoogleapis:masterfrom
daspecster:remove-misplaced-vision-fixtures
Sep 20, 2016
Merged

Remove orphaned _fixtures.py.#2362
daspecster merged 2 commits intogoogleapis:masterfrom
daspecster:remove-misplaced-vision-fixtures

Conversation

@daspecster
Copy link
Copy Markdown
Contributor

@dhermes, sorry I missed this. It slipped by me in one of the PRs when I was rebasing from the rename/moving tests.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2016
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Sep 20, 2016

LGTM

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Sep 20, 2016

May also want to remove it from run_pylint:
https://github.com/GoogleCloudPlatform/google-cloud-python/blob/d3e28ce8ae5bee1a637a11d11227d294cfa8302c/scripts/run_pylint.py#L41

@daspecster
Copy link
Copy Markdown
Contributor Author

@dhermes, I just removed reference in run_pylint.py.

@dhermes
Copy link
Copy Markdown
Contributor

dhermes commented Sep 20, 2016

LGTM to merge

@daspecster daspecster merged commit 707ee67 into googleapis:master Sep 20, 2016
@daspecster daspecster deleted the remove-misplaced-vision-fixtures branch September 20, 2016 15:44
parthea pushed a commit that referenced this pull request Apr 1, 2026
This change can resolve multiple bug fixes in #2248: 
- `str.extract` doctest
- multiple blob ops failures
- `test_geo_x_non_point` and `test_geo_drop_duplicates`

Fixes internal issue 417774347 🦕

---------

Co-authored-by: Tim Sweña (Swast) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants