chore: librarian generate pull request: 20260401T071732Z#16500
chore: librarian generate pull request: 20260401T071732Z#16500cloud-sdk-librarian-robot wants to merge 1 commit intomainfrom
Conversation
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
There was a problem hiding this comment.
Code Review
This pull request updates several Google Cloud client libraries, adding new services to google-cloud-network-security and new methods like GenerateAppResource to google-cloud-ces and EstablishVolumePeering to google-cloud-netapp. It also introduces features such as Dataflow job pausing and Firestore TTL expiration offsets. Feedback highlights multiple instances in the REST transports for google-cloud-memorystore and google-cloud-netapp where logging logic incorrectly attempts to serialize the raw HTTP response instead of the parsed proto message. Furthermore, the removal of the UNIFIED_LARGE_CAPACITY enum value in google-cloud-netapp is noted as a breaking change that requires deprecation to maintain backward compatibility.
| response_payload = ( | ||
| memorystore.SharedRegionalCertificateAuthority.to_json(response) | ||
| ) |
There was a problem hiding this comment.
The to_json method is being called with the response object (the HTTP response) instead of the resp object (the parsed proto-plus message instance). This will cause an error when attempting to serialize the response for logging.
| response_payload = ( | |
| memorystore.SharedRegionalCertificateAuthority.to_json(response) | |
| ) | |
| response_payload = memorystore.SharedRegionalCertificateAuthority.to_json( | |
| resp | |
| ) |
| response | ||
| ) | ||
| except: |
There was a problem hiding this comment.
| logging.DEBUG | ||
| ): # pragma: NO COVER | ||
| try: | ||
| response_payload = ontap.ExecuteOntapGetResponse.to_json(response) |
There was a problem hiding this comment.
The to_json method is being called with the response object (the HTTP response) instead of the resp object (the parsed proto-plus message instance). This will cause an error when attempting to serialize the response for logging.
| response_payload = ontap.ExecuteOntapGetResponse.to_json(response) | |
| response_payload = ontap.ExecuteOntapGetResponse.to_json(resp) |
| logging.DEBUG | ||
| ): # pragma: NO COVER | ||
| try: | ||
| response_payload = ontap.ExecuteOntapPatchResponse.to_json(response) |
There was a problem hiding this comment.
The to_json method is being called with the response object (the HTTP response) instead of the resp object (the parsed proto-plus message instance). This will cause an error when attempting to serialize the response for logging.
| response_payload = ontap.ExecuteOntapPatchResponse.to_json(response) | |
| response_payload = ontap.ExecuteOntapPatchResponse.to_json(resp) |
| logging.DEBUG | ||
| ): # pragma: NO COVER | ||
| try: | ||
| response_payload = ontap.ExecuteOntapPostResponse.to_json(response) |
There was a problem hiding this comment.
The to_json method is being called with the response object (the HTTP response) instead of the resp object (the parsed proto-plus message instance). This will cause an error when attempting to serialize the response for logging.
| response_payload = ontap.ExecuteOntapPostResponse.to_json(response) | |
| response_payload = ontap.ExecuteOntapPostResponse.to_json(resp) |
| STORAGE_POOL_TYPE_UNSPECIFIED = 0 | ||
| FILE = 1 | ||
| UNIFIED = 2 | ||
| UNIFIED_LARGE_CAPACITY = 3 |
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
docs: update SelectiveGapicGeneration usage doc
PiperOrigin-RevId: 892649773
Library-IDs: googleapis-common-protos
Source-link: googleapis/googleapis@06a20b28
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
relax_safety_filtersin message.google.cloud.texttospeech.v1beta1.AdvancedVoiceOptionsis changedPiperOrigin-RevId: 892462011
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@e38f6d2a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Support
enable_textnormfor Gemini voices.PiperOrigin-RevId: 892462011
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@e38f6d2a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
markupin message.google.cloud.texttospeech.v1beta1.SynthesisInputis changedPiperOrigin-RevId: 892462011
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@e38f6d2a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Support safety settings for Gemini voices and deprecate
relax_safety_filtersPiperOrigin-RevId: 892462011
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@e38f6d2a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Mark
advanced_voice_optionsas optional.PiperOrigin-RevId: 892462011
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@e38f6d2a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
markupin message.google.cloud.texttospeech.v1beta1.StreamingSynthesisInputis changedPiperOrigin-RevId: 892462011
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@e38f6d2a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
advanced_voice_optionsin message.google.cloud.texttospeech.v1beta1.SynthesizeSpeechRequestis changedPiperOrigin-RevId: 892462011
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@e38f6d2a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
advanced_voice_optionsin message.google.cloud.texttospeech.v1beta1.SynthesizeSpeechRequestis changedPiperOrigin-RevId: 892460024
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@a481d8bc
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Support
enable_textnormfor Gemini voices.PiperOrigin-RevId: 892460024
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@a481d8bc
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Support safety settings for Gemini voices and deprecate
relax_safety_filtersPiperOrigin-RevId: 892460024
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@a481d8bc
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
markupin message.google.cloud.texttospeech.v1beta1.SynthesisInputis changedPiperOrigin-RevId: 892460024
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@a481d8bc
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
relax_safety_filtersin message.google.cloud.texttospeech.v1beta1.AdvancedVoiceOptionsis changedPiperOrigin-RevId: 892460024
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@a481d8bc
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Mark
advanced_voice_optionsas optional.PiperOrigin-RevId: 892460024
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@a481d8bc
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
markupin message.google.cloud.texttospeech.v1beta1.StreamingSynthesisInputis changedPiperOrigin-RevId: 892460024
Library-IDs: google-cloud-texttospeech
Source-link: googleapis/googleapis@a481d8bc
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add origin to AttributeContext.Request
PiperOrigin-RevId: 892442206
Library-IDs: googleapis-common-protos
Source-link: googleapis/googleapis@ebd1d23a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add support for generating app resources with LLM
PiperOrigin-RevId: 892390364
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@ddc4001f
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: update public libraries for CES v1beta
PiperOrigin-RevId: 892390364
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@ddc4001f
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: deprecate
root_agentin message.google.cloud.ces.v1beta.AgentToolin favor of newagentfield.PiperOrigin-RevId: 892390364
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@ddc4001f
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
root_agentin message.google.cloud.ces.v1beta.AgentToolis changedPiperOrigin-RevId: 892390364
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@ddc4001f
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add sha256 field to Package proto
PiperOrigin-RevId: 891887357
Library-IDs: google-cloud-dataflow-client
Source-link: googleapis/googleapis@06735550
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add Pausing/Yaml capabilities to public protos
PiperOrigin-RevId: 891736643
Library-IDs: google-cloud-dataflow-client
Source-link: googleapis/googleapis@3aab7be0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: update API common type documentation
PiperOrigin-RevId: 890591600
Library-IDs: googleapis-common-protos
Source-link: googleapis/googleapis@208f1989
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: update the navigation point usage enum documentation
PiperOrigin-RevId: 890102125
Library-IDs: google-maps-geocode
Source-link: googleapis/googleapis@77c78e90
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: make the Place ID format consistent
PiperOrigin-RevId: 890102125
Library-IDs: google-maps-geocode
Source-link: googleapis/googleapis@77c78e90
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add
expiration_offsettoFieldPiperOrigin-RevId: 890064766
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@1161dbcb
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: update documentation for
FieldPiperOrigin-RevId: 890064766
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@1161dbcb
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add CustomHostConfig to configure custom hostnames for private instances
PiperOrigin-RevId: 889991858
Library-IDs: google-cloud-securesourcemanager
Source-link: googleapis/googleapis@10ac2077
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Improve documentation for labels, pagination, and ListLocations
PiperOrigin-RevId: 889991858
Library-IDs: google-cloud-securesourcemanager
Source-link: googleapis/googleapis@10ac2077
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add force option to DeleteInstance request
PiperOrigin-RevId: 889991858
Library-IDs: google-cloud-securesourcemanager
Source-link: googleapis/googleapis@10ac2077
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add option to require code owner approval in branch rules
PiperOrigin-RevId: 889991858
Library-IDs: google-cloud-securesourcemanager
Source-link: googleapis/googleapis@10ac2077
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add INVALID_MERCHANT_ID to the ErrorReason enum for when the merchant_id field is not valid
PiperOrigin-RevId: 889816734
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@d3ad5e34
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add EU_POLITICAL_ADVERTISING_DECLARATION_REQUIRED to the ErrorReason enum for campaigns missing the EU political advertising declaration
PiperOrigin-RevId: 889816734
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@d3ad5e34
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Update and cleanup docs
PiperOrigin-RevId: 889789965
Library-IDs: google-cloud-network-security
Source-link: googleapis/googleapis@a4d528d0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Publish proto definitions for AuthzPolicy, TlsInspectionPolicy, GatewaySecurityPolicy, GatewaySecurityPolicyRule, and UrlList
PiperOrigin-RevId: 889789965
Library-IDs: google-cloud-network-security
Source-link: googleapis/googleapis@a4d528d0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Publish proto definitions for Intercept, Mirroring and SecurityProfileGroup
PiperOrigin-RevId: 889789965
Library-IDs: google-cloud-network-security
Source-link: googleapis/googleapis@a4d528d0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Publish proto definitions for SSG
PiperOrigin-RevId: 889789965
Library-IDs: google-cloud-network-security
Source-link: googleapis/googleapis@a4d528d0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
source_volumein message.google.cloud.netapp.v1.Backupis changedPiperOrigin-RevId: 889585893
Library-IDs: google-cloud-netapp
Source-link: googleapis/googleapis@a90dc55a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
typein message.google.cloud.netapp.v1.StoragePoolis changedPiperOrigin-RevId: 889585893
Library-IDs: google-cloud-netapp
Source-link: googleapis/googleapis@a90dc55a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
source_backupin message.google.cloud.netapp.v1.RestoreParametersis changedPiperOrigin-RevId: 889585893
Library-IDs: google-cloud-netapp
Source-link: googleapis/googleapis@a90dc55a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add ONTAP passthrough APIs
Adds the following new methods for direct ONTAP API interaction:
StoragePoolTypePiperOrigin-RevId: 889585893
Library-IDs: google-cloud-netapp
Source-link: googleapis/googleapis@a90dc55a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix: An existing value
UNIFIED_LARGE_CAPACITYis removed from enumStoragePoolTypePiperOrigin-RevId: 889585893
Library-IDs: google-cloud-netapp
Source-link: googleapis/googleapis@a90dc55a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: update various comments
PiperOrigin-RevId: 889289393
Library-IDs: googleapis-common-protos
Source-link: googleapis/googleapis@94bc991b
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: publish client batch config schema
PiperOrigin-RevId: 889289393
Library-IDs: googleapis-common-protos
Source-link: googleapis/googleapis@94bc991b
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: update license year
PiperOrigin-RevId: 889289393
Library-IDs: googleapis-common-protos
Source-link: googleapis/googleapis@94bc991b
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: publish new error reasons
PiperOrigin-RevId: 889289393
Library-IDs: googleapis-common-protos
Source-link: googleapis/googleapis@94bc991b
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: fix documentation formatting
PiperOrigin-RevId: 889289393
Library-IDs: googleapis-common-protos
Source-link: googleapis/googleapis@94bc991b
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@59d5f2b4
(exclusive) and
googleapis/googleapis@06a20b28
(inclusive).
Librarian Version: v0.0.0-20260326184039-cac5ae324799
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:234b9d1f2ddb057ed7ac6a38db0bf8163d839c65c6cf88ade52530cddebce59e
Generation failed for