Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an automated mechanism to enforce a minimal Minimum Supported Rust Version (MSRV) for the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new CI script, ci/check_msrv_is_minimal.sh, to ensure the project's MSRV is not unintentionally increased. The script is also integrated into the pre-push git hook. The implementation is well-done, using a Python script to handle the version comparison logic. I have one suggestion to simplify the shell script by avoiding the use of a temporary file. Also, please note that while the description mentions an update to .github/workflows/ci.yml, this file was not part of the changes in this PR.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2812 +/- ##
=======================================
Coverage 88.14% 88.14%
=======================================
Files 20 20
Lines 5450 5450
=======================================
Hits 4804 4804
Misses 646 646 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This change adds a new CI script `ci/check_msrv_is_minimal.sh` that verifies that the package's MSRV is strictly lower than any version specified in `package.metadata.build-rs`. This ensures that we don't accidentally bump our MSRV unnecessarily. The check is added to: - `.github/workflows/ci.yml` as a new job. - `githooks/pre-push` to be run locally. The script implementation uses a Python script embedded via heredoc and executed via `python3 -c` for better readability and maintainability.
joshlf
force-pushed
the
add-msrv-minimal-check
branch
from
f3f7ea5 to
71337ff
Compare
3 participants
This change adds a new CI script
ci/check_msrv_is_minimal.shthat verifies that the package's MSRV is strictly lower than any version specified inpackage.metadata.build-rs. This ensures that we don't accidentally bump our MSRV unnecessarily.The check is added to:
.github/workflows/ci.ymlas a new job.githooks/pre-pushto be run locally.The script implementation uses a Python script embedded via heredoc and a temporary file for better readability and maintainability.