Skip to content

chore: light refactoring - #395

Closed
vincentkoc wants to merge 3 commits into
google:masterfrom
vincentkoc:master
Closed

chore: light refactoring#395
vincentkoc wants to merge 3 commits into
google:masterfrom
vincentkoc:master

Conversation

@vincentkoc

Copy link
Copy Markdown

Some light refactoring and clean-up

  • Remove excessive if/else
  • f-name function use where possible

@dbieber

dbieber commented Dec 9, 2022

Copy link
Copy Markdown
Collaborator

Thanks for looking into these changes, however some notes preventing merge:

  • We cannot use f-strings since we still support Python 2.7
  • I don't view replacing multi-line if/else with a ternary if-else as a strict improvement -- there are readability tradeoffs. i.e. for _GetCurrentCommand I think it reduces readability.

@vincentkoc vincentkoc closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants