Skip to content

feat: sync tool for repo-based git enumeration flags allowlist - #5800

Open
Ly-Joey wants to merge 9 commits into
google:masterfrom
Ly-Joey:feat-repo-cab-allowlist-sync-tool
Open

feat: sync tool for repo-based git enumeration flags allowlist#5800
Ly-Joey wants to merge 9 commits into
google:masterfrom
Ly-Joey:feat-repo-cab-allowlist-sync-tool

Conversation

@Ly-Joey

@Ly-Joey Ly-Joey commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Add a tool to sync repo-based git analysis flags allowlist entries from yaml to datastore.

Related: #5797
(Stack PR makes me sad)

@Ly-Joey
Ly-Joey force-pushed the feat-repo-cab-allowlist-sync-tool branch from db1789e to 9bfb442 Compare August 6, 2026 01:45
@Ly-Joey
Ly-Joey marked this pull request as ready for review August 6, 2026 01:46
@Ly-Joey
Ly-Joey requested a review from another-rex August 7, 2026 05:21
@Ly-Joey Ly-Joey changed the title feat: sync tool for repo-based CAB allowlist feat: sync tool for repo-based git enumeration flags allowlist Aug 7, 2026
Ly-Joey added a commit that referenced this pull request Aug 7, 2026
#5800 added a README.md and triggered a markdown link scan across
osv.dev.
This PR attempts to fix the issues and unblock myself.
@Ly-Joey
Ly-Joey force-pushed the feat-repo-cab-allowlist-sync-tool branch from 4e63b4c to 0c90492 Compare August 7, 2026 06:13
Comment on lines +19 to +27
type RepoAllowListEntity struct {
Key *datastore.Key `datastore:"__key__"`
Type string `datastore:"type"`
Value string `datastore:"value"`
ConsiderAllBranches bool `datastore:"consider_all_branches"`
CherrypicksIntroduced bool `datastore:"cherrypicks_introduced"`
CherrypicksFixed bool `datastore:"cherrypicks_fixed"`
CherrypicksLimit bool `datastore:"cherrypicks_limit"`
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using the go models. (Which I know you can't really do right now because it's not a stacked PR)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a TODO for now, will get it done after I merge #5797 today.

Comment thread tools/repo-allowlist-sync/main.go Outdated
Comment thread tools/repo-allowlist-sync/main.go
Comment thread tools/repo-allowlist-sync/main.go Outdated
Comment thread tools/repo-allowlist-sync/main.go Outdated
Comment thread tools/repo-allowlist-sync/main.go
Comment thread tools/repo-allowlist-sync/main.go Outdated

@another-rex another-rex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add a --validate flag, similar to how source_sync.py has for validating the yaml keys and regexes are correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants