Wolo/context unif v2 pr1 move#822
Draft
wolo-lab wants to merge 2 commits into
Draft
Conversation
…ntations into agent package
Eliminates the agent.invocationContext / agent.callbackContext /
agent.callbackContextState duplicates that mirrored impls in
internal/context/. The implementations now live exclusively in agent/,
where the interfaces themselves are defined. No more cycle dance via
internal/context just to satisfy interface-implements-interface
requirements.
Three new files in agent/:
- invocation_context.go: invocationContext + NewInvocationContext +
InvocationContextParams.
- readonly_context.go: readonlyContext + NewReadonlyContext.
- callback_context.go: callbackContext + callbackContextState +
internalArtifacts (delta-tracking artifact wrapper) + the
NewCallbackContext / NewCallbackContextWithDelta constructors.
Removes from agent/agent.go: ~146 lines of duplicate impls.
(*agent).Run no longer constructs a fresh invocationContext literal —
it uses NewInvocationContext directly. runBeforeAgentCallbacks /
runAfterAgentCallbacks switched to NewCallbackContextWithDelta and
hold the EventActions delta locally rather than reaching into the
context's private field.
internal/context/ still exists with its own duplicate impls — a
follow-up commit converts those into thin aliases over agent.NewX,
so all existing callers keep compiling unchanged.
Verified: go build ./...; go test ./...; both pass.
internal/context becomes a deprecated re-export layer. The three
production files (invocation_context.go, callback_context.go,
readonly_context.go) shrink from ~300 lines of duplicate impls to
~50 lines of 'var NewX = agent.NewX' aliases. All ~17 callers of
internal/context.NewInvocationContext / NewCallbackContext /
NewReadonlyContext continue compiling unchanged.
Other changes:
* Add agent.InvocationOf to recover the underlying InvocationContext
from a NewReadonlyContext-produced ReadonlyContext (replaces the
type assertion in util/instructionutil/instruction.go that reached
into icontext.ReadonlyContext.InvocationContext).
* util/instructionutil drops the icontext import and uses
agent.InvocationOf instead.
* Move TestReadonlyContext / TestCallbackContext from
internal/context/context_test.go into agent/readonly_context_test.go
and agent/callback_context_test.go (covering the new canonical
impls in agent). Delete internal/context/context_test.go (the
TestWithContext sibling already exists in agent/agent_test.go).
* internal/toolinternal: stop maintaining a duplicate internalArtifacts
wrapper. NewToolContext now relies on the embedded CallbackContext
(returned by agent.NewCallbackContextWithDelta) for Artifacts
delta tracking — eliminates the double-wrapping bug where
toolContext.Artifacts() shadowed the cbCtx-provided wrapper.
Verified: go build ./...; go test ./...; both pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
A clear and concise description of what the problem is.
Solution:
A clear and concise description of what you want to happen and why you choose
this solution.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed go test results.
Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.