Bump the go_modules group across 1 directory with 2 updates#1
Closed
dependabot[bot] wants to merge 2 commits into
Closed
Bump the go_modules group across 1 directory with 2 updates#1dependabot[bot] wants to merge 2 commits into
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps the go_modules group with 2 updates in the / directory: [golang.org/x/crypto](https://github.com/golang/crypto) and [golang.org/x/net](https://github.com/golang/net). Updates `golang.org/x/crypto` from 0.27.0 to 0.35.0 - [Commits](golang/crypto@v0.27.0...v0.35.0) Updates `golang.org/x/net` from 0.29.0 to 0.38.0 - [Commits](golang/net@v0.29.0...v0.38.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.35.0 dependency-type: indirect dependency-group: go_modules - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect dependency-group: go_modules ... Signed-off-by: dependabot[bot] <[email protected]>
Contributor
Author
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
4 tasks
wolo-lab
added a commit
that referenced
this pull request
Apr 28, 2026
wolo-lab
added a commit
that referenced
this pull request
Apr 28, 2026
9 tasks
wolo-lab
added a commit
that referenced
this pull request
May 12, 2026
…rs to import agent directly Sweeps the 28 importers of internal/context (alias 'icontext' or 'contextinternal') to use agent.NewX directly. The alias layer introduced in PR #1 was a transitional stage; with PR #2 (unified agent.Context interface) landed, no consumer needs internal/context any more. Mechanical changes: * `icontext.NewInvocationContext` → `agent.NewInvocationContext` (most uses) * `icontext.InvocationContextParams` → `agent.InvocationContextParams` * `icontext.NewCallbackContext` → `agent.NewCallbackContext` (2 uses) * `icontext.NewCallbackContextWithDelta` → `agent.NewCallbackContextWithDelta` (8 uses) * `icontext.NewReadonlyContext` → `agent.NewReadonlyContext` (3 uses) Per-file: 28 importer files lose their `icontext "…/internal/context"` import line. `internal/toolinternal/context_test.go` had a different alias name (`contextinternal`); also rewritten. One ad-hoc fix: `agent/remoteagent/v2/utils_test.go` had a local variable named `agent` shadowing the package name; renamed to `a` (unrelated to the sweep but exposed by it). Then deletes `internal/context/` entirely. The package no longer exists; `agent` is the single home for canonical context constructors. Verified: go build ./...; go vet ./...; go test ./...; all pass.
9 tasks
wolo-lab
added a commit
that referenced
this pull request
May 12, 2026
…#1) Same goal as wolo/context_unif_v2_pr1_move (eliminate the 3 pairs of duplicate context impls + the duplicate internalArtifacts helper), opposite execution: keeps existing implementations in agent/agent.go instead of moving them to new files. What's added to agent/agent.go (~146 lines): * internalArtifacts wrapper (delta-tracking for Save). * NewCallbackContext / NewCallbackContextWithDelta constructors. * artifacts field on callbackContext + updated Artifacts() to return the wrapper (bug fix: previously returned unwrapped Artifacts, so Save() in callbacks didn't record into EventActions.ArtifactDelta). * NewInvocationContext + InvocationContextParams. * readonlyContext struct + 8 methods + NewReadonlyContext. * InvocationOf helper (returns underlying InvocationContext from a NewReadonlyContext-produced ReadonlyContext). * runBeforeAgentCallbacks / runAfterAgentCallbacks switched from raw struct literal to newCallbackContextImpl (no behavioural change — the new bug fix takes effect either way). What's removed: * internal/context/{invocation,callback,readonly}_context.go shrink to thin alias layers (var NewX = agent.NewX). * internal/context/context_test.go deleted (its TestWithContext sibling already exists in agent/agent_test.go; the other two tests can be re-added in agent/ if desired). * internal/toolinternal.internalArtifacts dropped (toolContext now relies on the embedded CallbackContext for Artifacts wrapping — eliminates double-wrapping bug). * util/instructionutil drops the icontext import; uses agent.InvocationOf instead of *icontext.ReadonlyContext type assertion. Trade-off vs the canonical PR #1: * agent/agent.go grows from 521 to ~660 lines (mixing Agent + Run + Context impls + helpers in one file). * 7 files touched instead of 13; +168/-352 = -184 lines net, versus +489/-537 = -48 net for PR #1. ~136 lines smaller diff. * No new files in agent/ (3 fewer in git status). This branch exists for comparison; whichever direction we pick gets PRs #2 and #3 stacked on top. Verified: go build ./...; go vet ./...; go test ./...; all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Bumps the go_modules group with 2 updates in the / directory: golang.org/x/crypto and golang.org/x/net.
Updates
golang.org/x/cryptofrom 0.27.0 to 0.35.0Commits
7292932ssh: limit the size of the internal packet queue while waiting for KEXf66f74bacme/autocert: check host policy before probing the cacheb0784b7x509roots/fallback: drop obsolete build constraint911360call: bump golang.org/x/crypto dependencies of asm generators89ff08dall: upgrade go directive to at least 1.23.0 [generated]e47973ball: update certs for go1.249290511go.mod: update golang.org/x dependenciesfa5273ex509roots/fallback: update bundlea8ea4bessh: add ServerConfig.PreAuthConnCallback, ServerPreAuthConn (banner) interface71d3a4cacme: support challenges that require the ACME client to send a non-empty JSO...Updates
golang.org/x/netfrom 0.29.0 to 0.38.0Commits
e1fcd82html: properly handle trailing solidus in unquoted attribute value in foreign...ebed060internal/http3: fix build of tests with GOEXPERIMENT=nosynctest1f1fa29publicsuffix: regenerate table1215081http2: improve error when server sends HTTP/1312450ehtml: ensure <search> tag closes <p> and update tests09731f9http2: improve handling of lost PING in Server55989e2http2/h2c: use ResponseController for hijacking connections2914f46websocket: re-recommend gorilla/websocket99b3ae0go.mod: update golang.org/x dependencies85d1d54go.mod: update golang.org/x dependenciesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.