feat: add more rule check #4601
Open
+234
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuluo-yx <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds six new validation rules to the GoFrame validation package for common string pattern validations. The rules include alpha, alpha-num, alpha-dash, numeric, lowercase, and uppercase validations.
- Implements string pattern validators using regex matching
- Follows the existing builtin validation rule pattern
- Adds support for common validation scenarios
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| util/gvalid/internal/builtin/builtin_alpha.go | Adds validation rule for alphabetic characters only (a-z, A-Z) |
| util/gvalid/internal/builtin/builtin_alpha_num.go | Adds validation rule for alpha-numeric characters (a-z, A-Z, 0-9) |
| util/gvalid/internal/builtin/builtin_alpha_dash.go | Adds validation rule for alpha-numeric characters with hyphens and underscores |
| util/gvalid/internal/builtin/builtin_lowercase.go | Adds validation rule for lowercase alphabetic characters only (a-z) |
| util/gvalid/internal/builtin/builtin_numeric.go | Adds validation rule for numeric strings only (0-9) |
| util/gvalid/internal/builtin/builtin_uppercase.go | Adds validation rule for uppercase alphabetic characters only (A-Z) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more check rules