Skip to content

add option for cache unstructured#727

Merged
qmhu merged 1 commit intogocrane:mainfrom
whitebear009:cache-unstructured
Apr 7, 2023
Merged

add option for cache unstructured#727
qmhu merged 1 commit intogocrane:mainfrom
whitebear009:cache-unstructured

Conversation

@whitebear009
Copy link
Copy Markdown
Member

What type of PR is this?

optimization

What this PR does / why we need it:

Currently craned use unstructured object in many scenarios.
The controller-runtime client does not use cache when reading unstructured, which may cause slow performance, but enabling cache will increase memory usage.
So an option is added to allow users to choose whether to enable.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@github-actions
Copy link
Copy Markdown
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-03-30 18:09
Git Version: f26c086

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-727-f26c086 docker pull gocrane/crane-agent:pr-727-f26c086
dashboard:pr-727-f26c086 docker pull gocrane/dashboard:pr-727-f26c086
metric-adapter:pr-727-f26c086 docker pull gocrane/metric-adapter:pr-727-f26c086
craned:pr-727-f26c086 docker pull gocrane/craned:pr-727-f26c086

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-727-f26c086 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-727-f26c086 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-727-f26c086 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-727-f26c086 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-727-f26c086 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-727-f26c086
dashboard:pr-727-f26c086 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-727-f26c086
metric-adapter:pr-727-f26c086 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-727-f26c086
craned:pr-727-f26c086 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-727-f26c086

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-727-f26c086 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-727-f26c086 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-727-f26c086 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-727-f26c086 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-727-f26c086 docker pull ghcr.io/gocrane/crane/crane-agent:pr-727-f26c086
dashboard:pr-727-f26c086 docker pull ghcr.io/gocrane/crane/dashboard:pr-727-f26c086
metric-adapter:pr-727-f26c086 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-727-f26c086
craned:pr-727-f26c086 docker pull ghcr.io/gocrane/crane/craned:pr-727-f26c086

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-727-f26c086 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-727-f26c086 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-727-f26c086 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-727-f26c086 crane/crane

@whitebear009
Copy link
Copy Markdown
Member Author

@qmhu PTAL, thanks

Copy link
Copy Markdown
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qmhu qmhu merged commit f25920f into gocrane:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants