Skip to content

New Crane Dashboard #446

Merged
zsnmwy merged 1 commit intogocrane:mainfrom
zsnmwy:feat/dashboard/recommand
Aug 4, 2022
Merged

New Crane Dashboard #446
zsnmwy merged 1 commit intogocrane:mainfrom
zsnmwy:feat/dashboard/recommand

Conversation

@zsnmwy
Copy link
Copy Markdown
Member

@zsnmwy zsnmwy commented Jul 30, 2022

What type of PR is this?

image

image

image

A lot of changes to the dashboard.
I do some refactoring based on the old version.
But it still needs to do many jobs to make it available.

Dashboard

  • metrics display (may need a lot of time to test the PSQL...)

Cost

  • cost display group by Workload Optimize
  • jump to different pages based on the cost items.

Workload Optimize

  • i18n
  • Local Table Pagination
  • Search
  • Sort Data
  • Some fields may need to change

Special notes for your reviewer:

You must use the latest craned from the source code.
I dev based on finops-docker.pkg.coding.net/gocrane/crane/craned:pr-439-03f3c70.
You can use this image directly.
And use the dashboard image from this pr actions.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 30, 2022

♻️ PR Preview cb54096 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 30, 2022

🎉 Successfully Build Images.

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-446-cb54096 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-446-cb54096
dashboard:pr-446-cb54096 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-446-cb54096
metric-adapter:pr-446-cb54096 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-446-cb54096
craned:pr-446-cb54096 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-446-cb54096

@qmhu qmhu modified the milestone: 0.7.0 Aug 1, 2022
@zsnmwy zsnmwy force-pushed the feat/dashboard/recommand branch 9 times, most recently from e14c526 to f2b0215 Compare August 3, 2022 14:19
Signed-off-by: zsnmwy <[email protected]>
@zsnmwy zsnmwy force-pushed the feat/dashboard/recommand branch from f2b0215 to cb54096 Compare August 3, 2022 14:27
Copy link
Copy Markdown
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@zsnmwy zsnmwy merged commit bd19aae into gocrane:main Aug 4, 2022
@qmhu qmhu changed the title [WIP] Dashboard New Crane Dashboard Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants