🎊 PR Preview 76d5644 has been successfully built and deployed to https://gocrane-crane-preview-pr-273.surge.sh

🕐 Build time: 1.573s

_{🤖 By surge-preview}

@chenkaiyue Please take a look

Thanks for your contributions. Have you tested in Kind or K3S, maybe you can paste test images here?

🎉 Successfully Build Images.

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

I have some tests in finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-273-c744466, k8s v1.23.5.

Connect container runtime endpoint successfully, but have some permission problems.

    1 connection.go:42] connect endpoint 'unix:///var/run/dockershim.sock', make sure you are running as root and the endpoint has been started
    1 connection.go:26] Connect using endpoint 'unix:///run/containerd/containerd.sock' with '2s' timeout
    1 connection.go:44] Connected successfully using endpoint: unix:///run/containerd/containerd.sock
    1 agent.go:157] Failed to get noderesource tsp configmap : configmaps "noderesource-tsp-template" is forbidden: User "system:serviceaccount:crane-system:crane-agent" cannot
    1 agent.go:202] Discover the presence of old noderesource tsp and try to contrast the changes: noderesource-demo
    1 agent.go:206] Discover the presence of old noderesource tsp and the Tsp rules have been changed: noderesource-demo
    1 request.go:936] Error in request: resource name may not be empty
    1 agent.go:210] Failed to update noderesource tsp noderesource-demo : resource name may not be empty
    1 agent.go:60] resource name may not be empty

k3s connect container runtime endpoint successfully:

https://github.com/gocrane/helm-charts/pull/46/files is this pr related to this change?

https://github.com/gocrane/helm-charts/pull/46/files is this pr related to this change?

yes
see: https://github.com/gocrane/crane/pull/273/files#diff-f915bb96af9fbe90557cb2b8ede3eb7903ddae1297dad168074182cd3e55eb2c

https://github.com/gocrane/helm-charts/pull/46/files is this pr related to this change?

ok

I have some tests in finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-273-c744466, k8s v1.23.5.

Connect container runtime endpoint successfully, but have some permission problems.

    1 connection.go:42] connect endpoint 'unix:///var/run/dockershim.sock', make sure you are running as root and the endpoint has been started
    1 connection.go:26] Connect using endpoint 'unix:///run/containerd/containerd.sock' with '2s' timeout
    1 connection.go:44] Connected successfully using endpoint: unix:///run/containerd/containerd.sock
    1 agent.go:157] Failed to get noderesource tsp configmap : configmaps "noderesource-tsp-template" is forbidden: User "system:serviceaccount:crane-system:crane-agent" cannot
    1 agent.go:202] Discover the presence of old noderesource tsp and try to contrast the changes: noderesource-demo
    1 agent.go:206] Discover the presence of old noderesource tsp and the Tsp rules have been changed: noderesource-demo
    1 request.go:936] Error in request: resource name may not be empty
    1 agent.go:210] Failed to update noderesource tsp noderesource-demo : resource name may not be empty
    1 agent.go:60] resource name may not be empty

@qmhu @chenkaiyue Should this bug be fixed by this pr or fixed by a separate pr?

kind connect container runtime endpoint successfully:

Please squash these commits.

Please squash these commits.

Finish

/LGTM

nice job!

/LGTM