Moved clear after activate in framebuffer.py doc.#189
Merged
Conversation
You have to clear when the framebuffer is bound, or else it is just clearing the window and not your renderbuffers.
sebftw
added a commit
to sebftw/glumpy
that referenced
this pull request
Jan 22, 2019
Instead of calling window.clear() when we have a framebuffer activated we should call framebuffer.clear(). Then it makes sure to clear the renderbuffers that are set. Of course merging this change will make my other pull request redundant: glumpy#189
Member
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You have to clear when the framebuffer is bound, or else it is just clearing the window and not your renderbuffers.