WIP: use cygpath.exe to convert Windows paths and respect mount-points#639
WIP: use cygpath.exe to convert Windows paths and respect mount-points#639ankostis wants to merge 6 commits intogitpython-developers:masterfrom
cygpath.exe to convert Windows paths and respect mount-points#639Conversation
+ Always process paths, not only when starting from `cygdrive`.
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
- Coverage 92.57% 92.48% -0.09%
==========================================
Files 61 61
Lines 9968 9985 +17
==========================================
+ Hits 9228 9235 +7
- Misses 740 750 +10
Continue to review full report at Codecov.
|
|
@ankostis I happen to be on a merge-spree right now and wonder if this one is ready. Also I know you could just merge yourself when ready, I am just wondering :). Thank you. |
|
Sorry, I cannot respond confidently. But still not all TCs pass, but have no time to fix them. Apologies for me not being available. |
3 participants
Currently the
/cygdrive/mount-point is hard-coded in GitPython's conversionsgit/utils.pysince version 2.1.3 that Cygwin support was added. This PR purports to use Cygwin'scygpath -w | -uutility for path conversions.An added benefit is support out-of-the-box for MSYS2 which is a Cygwin clone based on the excellent pacman package manager that (at last) mounts Windows-drives under root(
/).It is still a WorkInProgress (WIP) because although all travis TCs pass on the POSIX part, appveyor now fails on all non-Cygwin builds; prior to this PR, it was only Cygwin builds that were failing in a couple of TCs: https://ci.appveyor.com/project/ankostis/gitpython/build/1.0.443).