Skip to content

test(bash-lint): cover Python runtime bash generator in REQUIRED_STEP_DISPLAY_NAMES#532

Draft
github-actions[bot] wants to merge 1 commit into
mainfrom
bash-hygiene/python-runtime-coverage-6566587275376c19
Draft

test(bash-lint): cover Python runtime bash generator in REQUIRED_STEP_DISPLAY_NAMES#532
github-actions[bot] wants to merge 1 commit into
mainfrom
bash-hygiene/python-runtime-coverage-6566587275376c19

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

What the lint found

The src/runtimes/python/extension.rs extension implements prompt_supplement(), which causes wrap_prompt_append() to emit a - bash: | step with displayName: "Append Python prompt" whenever the Python runtime is enabled. However, no fixture in FIXTURES included runtimes.python, so this bash body was never passed to shellcheck and had no quality story.

There was no lint failure because the step wasn't exercised at all — the gap was invisible until this audit.

How it was fixed

  • Rule: Step 4c — expand fixture coverage for a real, currently-unreached bash generator.
  • Fix: Added python: true to tests/fixtures/runtime-coverage-agent.md so the Python extension's prompt_supplement bash step is compiled and linted on every PR.
  • Tracking: Added "Append Python prompt" to REQUIRED_STEP_DISPLAY_NAMES in tests/bash_lint_tests.rs so a future rename or removal of this step surfaces as a test failure rather than silently slipping by.
  • Files touched: tests/fixtures/runtime-coverage-agent.md, tests/bash_lint_tests.rs.

Verification

All checks pass on the branch:

ENFORCE_BASH_LINT=1 cargo test --test bash_lint_tests -- --nocapture
# test result: ok. 2 passed; 0 failed

cargo test
# All test suites pass

cargo clippy --all-targets
# No new errors or warnings introduced

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • dev.azure.com
  • releaseassets.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "dev.azure.com"
    - "releaseassets.githubusercontent.com"

See Network Configuration for more information.

Generated by Bash Step Hygiene Auditor · ● 2.7M ·

…_DISPLAY_NAMES

Add python: true to runtime-coverage-agent.md so the lint exercises the
'Append Python prompt' bash step emitted by src/runtimes/python/extension.rs
via wrap_prompt_append(). Track the step in REQUIRED_STEP_DISPLAY_NAMES so
the coverage check catches regressions if the generator is renamed or removed.

No fixture previously included the Python runtime, leaving this bash step
completely outside the shellcheck quality gate.

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants