test(bash-lint): cover Python runtime bash generator in REQUIRED_STEP_DISPLAY_NAMES#532
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
…_DISPLAY_NAMES Add python: true to runtime-coverage-agent.md so the lint exercises the 'Append Python prompt' bash step emitted by src/runtimes/python/extension.rs via wrap_prompt_append(). Track the step in REQUIRED_STEP_DISPLAY_NAMES so the coverage check catches regressions if the generator is renamed or removed. No fixture previously included the Python runtime, leaving this bash step completely outside the shellcheck quality gate. Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the lint found
The
src/runtimes/python/extension.rsextension implementsprompt_supplement(), which causeswrap_prompt_append()to emit a- bash: |step withdisplayName: "Append Python prompt"whenever the Python runtime is enabled. However, no fixture inFIXTURESincludedruntimes.python, so this bash body was never passed to shellcheck and had no quality story.There was no lint failure because the step wasn't exercised at all — the gap was invisible until this audit.
How it was fixed
python: truetotests/fixtures/runtime-coverage-agent.mdso the Python extension'sprompt_supplementbash step is compiled and linted on every PR."Append Python prompt"toREQUIRED_STEP_DISPLAY_NAMESintests/bash_lint_tests.rsso a future rename or removal of this step surfaces as a test failure rather than silently slipping by.tests/fixtures/runtime-coverage-agent.md,tests/bash_lint_tests.rs.Verification
All checks pass on the branch:
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
dev.azure.comreleaseassets.githubusercontent.comSee Network Configuration for more information.