This repository was archived by the owner on May 5, 2020. It is now read-only.
[2.3] Always convert Time and DateTime objects to local before converting to string#71
Open
haileys wants to merge 6 commits into2-3-githubfrom
Open
[2.3] Always convert Time and DateTime objects to local before converting to string#71haileys wants to merge 6 commits into2-3-githubfrom
haileys wants to merge 6 commits into2-3-githubfrom
Conversation
|
If we go this route, how should TimeWithZone behave? Right now, # <tt>:db</tt> format outputs time in UTC; all others output time in local.
# Uses TimeWithZone's +strftime+, so <tt>%Z</tt> and <tt>%z</tt> work correctly.
def to_s(format = :default)
return utc.to_s(format) if format == :db
if formatter = ::Time::DATE_FORMATS[format]
formatter.respond_to?(:call) ? formatter.call(self).to_s : strftime(formatter)
else
"#{time.strftime("%Y-%m-%d %H:%M:%S")} #{formatted_offset(false, 'UTC')}" # mimicking Ruby 1.9 Time#to_s format
end
end
alias_method :to_formatted_s, :to_s |
Author
|
@rsanheim Yeah, that's tricky. It should return local for us. I believe Rails 3 makes this configurable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks a whole bunch of Rails tests, which is to be expected because there was previously no timezone handling here at all.
cc @github/timezones @github/rails3 github/github#27189