Skip to content
This repository was archived by the owner on May 5, 2020. It is now read-only.

keep the original exception's backtrace#35

Open
technoweenie wants to merge 1 commit into2-3-githubfrom
restore-ar-log-backtraces
Open

keep the original exception's backtrace#35
technoweenie wants to merge 1 commit into2-3-githubfrom
restore-ar-log-backtraces

Conversation

@technoweenie
Copy link
Copy Markdown

@technoweenie technoweenie commented Jan 8, 2014

The StatementInvalid exception keeps the original exception's message, but not the backtrace. So, we end up getting a message and backtrace like:

ArgumentError: wrong number of arguments (1 for 2)

.../vendor/gems/1.9.3/ruby/1.9.1/gems/activerecord-2.3.14.github25/lib/active_record/connection_adapters/abstract_adapter.rb:228:in `rescue in log'
.../vendor/gems/1.9.3/ruby/1.9.1/gems/activerecord-2.3.14.github25/lib/active_record/connection_adapters/abstract_adapter.rb:205:in `log'

I want to know where that ArgumentError came from.

@technoweenie
keep the original exception's backtrace
76a0053 
We don't care about a backtrace pointing to #log
@mtodd
Copy link
Copy Markdown
Member

mtodd commented Jan 8, 2014

:shipit:

@haileys
Copy link
Copy Markdown

haileys commented Jan 8, 2014

Seems legit. In Ruby 2.1 we might even be able to use the new exception cause stuff for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@technoweenie @mtodd @haileys