This repository was archived by the owner on Jan 31, 2019. It is now read-only.
Remove ssl_version option from webhook#949
Merged
Merged
Conversation
Due to the SSLv3 POODLE issue, anyone who has SSLv3 set manually on their webhook won't be able to communicate with their servers. This especially impacts anyone who uses something like Heroku to host their integration. Given SSLv3 is insecure regardless, I think it's best to completely remove this option. The documentation also stated that you could set to SSLv2 but that isn't actually true in the code below. cc @jdpace @dbussink
Contributor
|
👍 on removing this option. |
Member
Author
|
We also checked all webhooks that currently specify the |
kdaigle
added a commit
that referenced
this pull request
Oct 16, 2014
Remove `ssl_version` option from webhook
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the SSLv3 POODLE issue, anyone who has SSLv3 set manually on their webhook won't be able to communicate with servers who (likely) dropped support for SSLv3. This also impacts anyone who uses something like Heroku to host their integration. Given SSLv3 is insecure regardless, I think it's best to completely remove this option.
The documentation also stated that you could set to SSLv2 but that isn't actually true in the code below. This clarifies and relies on TLS.
cc @jdpace @dbussink