Commit 65d34ef
feat: add post cleanup script to actions/setup to erase /tmp/gh-aw/ (#22938)
* feat: add post cleanup script to actions/setup to erase /tmp/gh-aw/
Co-authored-by: pelikhan <[email protected]>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/72f086e1-072b-4238-94cd-db1eaaca8353
* fix: use node24 in actions/setup action.yml
Co-authored-by: pelikhan <[email protected]>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/4290b5c1-bc7e-4de0-b83d-22929f106bad
* fix: add log message before deleting /tmp/gh-aw in post.js
Co-authored-by: pelikhan <[email protected]>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/28d17560-27f9-45e9-93b3-d67b3366236b
* Apply suggestions from code review
Co-authored-by: Copilot <[email protected]>
* fix: add actions/setup to .github/.agents checkout sparse-checkout to preserve post step
The activation job runs a second sparse checkout (`.github` and `.agents`) after
`./actions/setup`, which removed the `actions/setup/` directory from the workspace.
This caused the runner to fail with "Can't find 'action.yml'" when trying to execute
the post step from `post.js`.
Adding `actions/setup` to the sparse-checkout list ensures the action files persist
throughout the job so the cleanup post step can run successfully.
Co-authored-by: pelikhan <[email protected]>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/aa4d847b-c8d6-40ed-b847-f69812c03f79
* Add changeset [skip-ci]
* fix: scope actions/setup sparse-checkout to dev mode only
In release/script/action modes the action is fetched by the runner into
its action cache (not the workspace), so the second sparse checkout does
not affect it. Only dev mode uses ./actions/setup (a workspace-local
path), so actions/setup only needs to be included in the sparse-checkout
in that case.
- Add extraPaths variadic parameter to GenerateGitHubFolderCheckoutStep
- Pass "actions/setup" only when actionMode.IsDev()
- Add TestGenerateCheckoutGitHubFolderForActivation_ActionsModeSetupPath
to cover all four action modes
- Add TestGenerateGitHubFolderCheckoutStep_ExtraPaths for extraPaths API
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/32ba44a4-9104-4a76-a059-9bb102a971b8
Co-authored-by: pelikhan <[email protected]>
* fix: update wasm golden files and accept node24 in actions-build validation
- Update wasm_golden test fixtures after lock file recompilation
(sparse-checkout change caused output differences in basic-copilot,
smoke-copilot, and with-imports golden files)
- Extend validateActionYml in actions_build_command.go to accept any
nodeXX runtime (not just node20), fixing actions-build CI failure
caused by actions/setup switching to node24
- Add test case for valid node24 action and update error message
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/01c06a7d-a428-4b7e-929a-da0e4efafbe5
Co-authored-by: pelikhan <[email protected]>
* fix: use sudo rm -rf in post.js to handle root-owned files in /tmp/gh-aw
Files written by Docker containers or privileged scripts during the job
are owned by root, causing fs.rmSync to fail with EACCES. GitHub-hosted
runners have passwordless sudo, so try `sudo rm -rf` first and fall back
to fs.rmSync for self-hosted runners without sudo.
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/4905a7a0-58f6-4f2f-b856-8cae909dc609
Co-authored-by: pelikhan <[email protected]>
---------
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: Peli de Halleux <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>1 parent 4245eab commit 65d34ef
189 files changed
Lines changed: 355 additions & 17 deletions
File tree
- .changeset
- .github/workflows
- actions/setup
- pkg
- cli
- workflow
- testdata/wasm_golden/TestWasmGolden_CompileFixtures
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments