Add mention of .mp4 .mov - #3571
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
|
👋 @Jolg42 Could you please fill out the What's being changed and complete the checks in the pull request template in the top comment, then I'll get this triaged for review ✨ |
|
Hi @janiceilene 👋 I just updated it, it's a small change 😃 |
janiceilene
added
content
|
Thanks so much for that additional context and a link to your changes in staging @Jolg42! I've triaged this for the team to review ✨ |
janiceilene
added
the
waiting for review
felicitymay
left a comment
felicitymay
left a comment
There was a problem hiding this comment.
Hi @Jolg42 👋🏻
Thanks for your PR and for the clear summary of your changes (and why you were suggesting them). This makes it so much easier to review the changes 😄
The changes you've made look great and follow our guidelines well ✨ However, there are several extra considerations for documenting beta features and I've added comments with the changes we'll need to make before we can merge this PR.
This is the first time an OS contributor has updated the docs for a beta feature, so we don't have any guidance on this currently.
…n-issues-and-pull-requests.md Co-authored-by: Felicity Chapman <[email protected]>
…n-issues-and-pull-requests.md Co-authored-by: Felicity Chapman <[email protected]>
|
No problem! I added your suggestions 💯 Feel free to edit the code of course 👍 |
felicitymay
left a comment
felicitymay
left a comment
There was a problem hiding this comment.
Thanks for applying the suggested changes so quickly.
It looks as if your changes show up in the GitHub.com article only, as intended:
This looks ready to merge 😄
|
Yay! 🎊 Have a great day! |
<!-- Thank you for contributing to this project! You must fill out the information below before we can review this pull request. By explaining why you're making a change (or linking to an issue) and what changes you've made, we can triage your pull request to the best possible team for review. --> ### Why: <!-- Paste the issue link or number here --> Closes: <!-- If there's an existing issue for your change, please link to it above. If there's _not_ an existing issue, please open one first to make it more likely that this update will be accepted: https://github.com/github/docs/issues/new/choose. --> ### What's being changed (if available, include any code snippets, screenshots, or gifs): <!-- Let us know what you are changing. Share anything that could provide the most context. If you made changes to the `content` directory, a table will populate in a comment below with links to the review and current production articles. --> ### Check off the following: - [ ] A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff. - [ ] The changes in this PR meet [the docs fundamentals that are required for all content](http://docs.github.com/en/contributing/writing-for-github-docs/about-githubs-documentation-fundamentals). - [ ] All CI checks are passing and the changes look good in the review environment.
3 participants
Why:
Video files support was added to attachments:
https://github.blog/changelog/2021-02-01-expanded-support-for-video-uploads/
https://github.blog/changelog/2020-12-16-video-upload-public-beta/
Closes [issue link]
What's being changed:
The original page
https://docs.github.com/en/github/managing-your-work-on-github/file-attachments-on-issues-and-pull-requests
The new deployed version with changes
https://docs-3571--patch-1.herokuapp.com/en/github/managing-your-work-on-github/file-attachments-on-issues-and-pull-requests
I added a mention of video files upload/attachment
Check off the following: