Add changenotes.mts assemble command to move changenotes to CHANGELOG.md - #4155
Open
mario-campos wants to merge 12 commits into
Open
mario-campos wants to merge 12 commits into
mario-campos wants to merge 12 commits into
Conversation
Changing `NO_CHANGES_STR` to just be the text will make it easier to insert/use. To not break anything, I added the deleted newlines to the locations where `NO_CHANGES_STR` was used.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Empty or invalid inputs can mutate the changelog, and deletion failures can leave a partially completed flush.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 3
Open (3)
What changed in this PR
Adds a development command to move unreleased changenotes into CHANGELOG.md.
Changes:
- Adds the
changenotes.mts flushcommand. - Adds changelog insertion helpers and unit tests.
- Normalizes the default no-changes placeholder.
| File | Description |
|---|---|
pr-checks/changenotes.mts |
Implements changenote flushing and deletion. |
pr-checks/changelog.ts |
Adds unreleased-section insertion logic. |
pr-checks/changelog.test.ts |
Tests header parsing and insertion behavior. |
pr-checks/bundle-changelog.test.ts |
Updates assertions for the normalized placeholder. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mario-campos
force-pushed
the
mario-campos/merge-changenotes
branch
from
September 18, 2026 16:05
36485ce to
ff33914
Compare
mbg
reviewed
Sep 18, 2026
mbg
left a comment
mbg
left a comment
Member
There was a problem hiding this comment.
Thanks for preparing this! I think functionally this looks fine, but as always, I have had a few comments and suggestions on the details of this initial implementation.
This will be used by the `pr-checks/changenotes.mts` script to "compile" the latest release entry of CHANGELOG.md.
This command will "flush" or move the changenotes in the `unreleased-change-notes` directory to the `[UNRELEASED]` section of the CHANGELOG.md file.
mario-campos
force-pushed
the
mario-campos/merge-changenotes
branch
from
September 18, 2026 18:47
ff33914 to
977b29b
Compare
mario-campos
changed the title
changenotes.mts flush command to move changenotes to CHANGELOG.mdchangenotes.mts assemble command to move changenotes to CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the
pr-checks/changenotes.mtsfunctionality by adding anassemblecommand that will be used to "flush" (or empty the contents ofunreleased-change-notes) to the[UNRELEASED]section ofCHANGELOG.md.This PR also replaces the use of constants
0and1for process exit codes with theExitCodetype from@actions/core.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
.test.tsfiles).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist