Merged
Conversation
hvitved
force-pushed
the
csharp/cfg/shared
branch
3 times, most recently
from
533f6f1 to
0f1d4b0
Compare
hvitved
force-pushed
the
csharp/cfg/shared
branch
2 times, most recently
from
3733bd5 to
c246f29
Compare
hvitved
force-pushed
the
csharp/cfg/shared
branch
from
c246f29 to
ab2bc38
Compare
tamasvajk
approved these changes
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR moves the language agnostic features of
ControlFlowGraphImpl.qll(as well as consistency tests) into a sharableControlFlowGraphImplShared.qll. It contains an interface for constructing a simple CFG (first,last, andsucc), as well as optional functionality for adding CFG splitting.The two commits should be reviewed individually.
https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/1272/https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/1288/