Skip to content

Avoid non-trivially shadowing string.toString() #21306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ginsbach merged 1 commit into from
Feb 11, 2026
Merged

Avoid non-trivially shadowing string.toString() #21306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Avoid non-trivially shadowing string.toString() 
Prepare libraries for a possible deprecation warning on shadowing
string.toString().

These instanceof classes were using this.(Type).method() to call
supertype methods, but super.method() is clearer and equivalent
for instanceof supertypes.
  • Loading branch information
@ginsbach
ginsbach committed Feb 10, 2026
commit f60d759a6593b30375fb9f39a643ff6615046400
2 changes: 1 addition & 1 deletion shared/regex/codeql/regex/nfa/ExponentialBackTracking.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ module Make<RegexTreeViewSig TreeImpl> {
)
}

string toString() { result = this.(InfiniteRepetitionQuantifier).toString() }
string toString() { result = super.toString() }
}

/**
Expand Down
24 changes: 12 additions & 12 deletions shared/regex/codeql/regex/nfa/NfaUtils.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,11 @@ module Make<RegexTreeViewSig TreeImpl> {
private class RegexpCharacterConstant instanceof RegExpConstant {
RegexpCharacterConstant() { this.isCharacter() }

string toString() { result = this.(RegExpConstant).toString() }
string toString() { result = super.toString() }

RegExpTerm getRootTerm() { result = this.(RegExpConstant).getRootTerm() }
RegExpTerm getRootTerm() { result = super.getRootTerm() }

string getValue() { result = this.(RegExpConstant).getValue() }
string getValue() { result = super.getValue() }
}

/**
Expand Down Expand Up @@ -578,11 +578,11 @@ module Make<RegexTreeViewSig TreeImpl> {
)
}

string toString() { result = this.(RegExpTerm).toString() }
string toString() { result = super.toString() }

RegExpTerm getAChild() { result = this.(RegExpTerm).getChild(_) }
RegExpTerm getAChild() { result = super.getChild(_) }

RegExpTerm getChild(int i) { result = this.(RegExpTerm).getChild(i) }
RegExpTerm getChild(int i) { result = super.getChild(i) }
}

/**
Expand All @@ -601,11 +601,11 @@ module Make<RegexTreeViewSig TreeImpl> {
)
}

string toString() { result = this.(RegExpTerm).toString() }
string toString() { result = super.toString() }

RegExpTerm getAChild() { result = this.(RegExpTerm).getAChild() }
RegExpTerm getAChild() { result = super.getAChild() }

RegExpTerm getChild(int i) { result = this.(RegExpTerm).getChild(i) }
RegExpTerm getChild(int i) { result = super.getChild(i) }
}

/**
Expand All @@ -621,11 +621,11 @@ module Make<RegexTreeViewSig TreeImpl> {
)
}

string toString() { result = this.(RegExpTerm).toString() }
string toString() { result = super.toString() }

RegExpTerm getAChild() { result = this.(RegExpTerm).getAChild() }
RegExpTerm getAChild() { result = super.getAChild() }

RegExpTerm getChild(int i) { result = this.(RegExpTerm).getChild(i) }
RegExpTerm getChild(int i) { result = super.getChild(i) }
}

/**
Expand Down
Loading