Adds a minimum required sed version to the documentation#480
Closed
craigerrington wants to merge 1 commit into
Closed
Adds a minimum required sed version to the documentation#480craigerrington wants to merge 1 commit into
craigerrington wants to merge 1 commit into
Conversation
the `-E` flag we use is only available in sed 4.3 and above.
|
I wonder if it would be better to downgrade the code that requires sed 4.3. That is, from: version=$(echo "$output" | sed -E -n 's/GitHub Enterprise( Server)? version (.*)/\2/p')to version=$(echo "$output" | sed -n 's/GitHub Enterprise\( Server\)\{0,1\} version \(.*\)/\2/p')In this case, it would not be necessary to document the I am not 100% sure of how portable the second code is. My first try used |
Member
|
We've gone the route of using a simplified |
bonsohi
pushed a commit
that referenced
this pull request
Aug 10, 2023
While investigating an unrelated issue, I noticed that some definitions in ghe-backup-config are present twice. The reason for this appears to be a faulty merge conflict resolution [1], as both parent commits [2, 3] only have a single copy of these definitions but the merge commit has duplicates. It seems that an unwieldy conflict came up while merging the progress-indicator with the master branch, as a result of which both the old and new locations of these definitions were accidentally kept, causing the duplication. This removes one copy of each definition to avoid confusion and potential future bugs. [1] 1eaf809 [2] a8e7eca [3] 8aaccc3
dooleydevin
pushed a commit
that referenced
this pull request
Aug 16, 2023
While investigating an unrelated issue, I noticed that some definitions in ghe-backup-config are present twice. The reason for this appears to be a faulty merge conflict resolution [1], as both parent commits [2, 3] only have a single copy of these definitions but the merge commit has duplicates. It seems that an unwieldy conflict came up while merging the progress-indicator with the master branch, as a result of which both the old and new locations of these definitions were accidentally kept, causing the duplication. This removes one copy of each definition to avoid confusion and potential future bugs. [1] 1eaf809 [2] a8e7eca [3] 8aaccc3 Co-authored-by: Patrick Lühne <[email protected]>
bonsohi
pushed a commit
that referenced
this pull request
Aug 29, 2023
While investigating an unrelated issue, I noticed that some definitions in ghe-backup-config are present twice. The reason for this appears to be a faulty merge conflict resolution [1], as both parent commits [2, 3] only have a single copy of these definitions but the merge commit has duplicates. It seems that an unwieldy conflict came up while merging the progress-indicator with the master branch, as a result of which both the old and new locations of these definitions were accidentally kept, causing the duplication. This removes one copy of each definition to avoid confusion and potential future bugs. [1] 1eaf809 [2] a8e7eca [3] 8aaccc3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-Eflag became available in sed 4.3 and above.There are still some extended support distros (SLES 11 at least) which are shipping with older versions, so I think it would be good to call out the minimum requirement.