Document not to use replica#436
Merged
Merged
Conversation
This was referenced Sep 6, 2018
This reverts commit 1984432. Safer to not mention this as it makes it too easy to shoot yourself in the foot.
lildude
changed the title
dooleydevin
pushed a commit
that referenced
this pull request
Aug 16, 2023
…p-restore-secret-scanning-encryption-keys Backport 351 for 3.8: Backup and restore secret scanning encrypted secrets encryption keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of housework to clean up a few stale PRs.
The first change introduces thePATHoption tobackup.config-examplewhich is useful to set for hosts where the required commands aren't in the user's default path and the implementer isn't in a position to change the user's path. We already honour this, so documenting it is all that's needed.Update: after internal discussions, reverted ☝️ as this makes it far too easy to make a mistake.
This makes the relevant part of #294 moot. The
pschange is no longer needed thanks to #435 .The second change makes it clear that backups need to be performed against the primary GitHub Enterprise instance. This is already enforced by Backup Utilities, but not yet documented.
This makes #398 moot.