Capture and display repository/gist warnings during cluster restore#423
Merged
Conversation
lildude
suggested changes
Aug 8, 2018
lildude
left a comment
lildude
left a comment
Member
There was a problem hiding this comment.
Just a little niggle with one of the tests.
| grep -q "dpages-cluster-restore-finalize OK" "$TRASHDIR/restore-out" | ||
|
|
||
| # verify no warnings printed | ||
| grep -qv "Warning" "$TRASHDIR/restore-out" |
Member
There was a problem hiding this comment.
This will always succeed if the restore-out file contains more than just "Warning" lines:
$ cat foo.out
Warning
baaa
$ grep -qv Warning foo.out; echo $?
0
$You would need to negate a successful find:
$ grep -q Warning foo.out; echo $?
0
$ ! grep -q Warning foo.out; echo $?
1
$ ! grep -q foo foo.out; echo $?
0
$
Contributor
Author
There was a problem hiding this comment.
Ah, thanks for that @lildude 🙇 Fix coming up.
Merged
dooleydevin
pushed a commit
that referenced
this pull request
Aug 16, 2023
…rror-msg-for-snapshots Backport 417 for 3.9: add msg in the logs for skipping snapshots
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in #386 allowed a backup to complete if a data consistency issue occured, printing a warning instead of causing a hard failure. Currently, an analogous situation exists for cluster restores; any errors along the way will cause the restore to fail. These may be minor issues that can be addressed with the help of GitHub support, and do not need to block the use of the destination cluster in the meantime.
This PR captures the stderr output of the repository and Gist finalize scripts from the cluster side, displaying them as warnings. Note that this will need a corresponding change on the Enterprise appliance side so that those scripts don't exit non-zero on error to take effect.