Don't fail a backup if the Management Console password isn't set#416
Merged
Conversation
lildude
approved these changes
Jul 14, 2018
lildude
left a comment
lildude
left a comment
Member
There was a problem hiding this comment.
Looks good and makes sense to me.
Merged
dooleydevin
added a commit
that referenced
this pull request
Jul 21, 2023
…ncrypted-column-keys Backport 331 for 3.7: Add encrypted column encryption keys to backup utils
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configuring a GitHub Enterprise cluster using automation on platforms such as AWS, the Management Console password is not required and setting it may be skipped. This causes the settings backup to fail, as
ghe-config secrets.manageexits non-zero due to the non-existent key.The change here causes
ghe-backup-settingsto print a warning instead; for example:@github/backup-utils Thoughts on this approach?