Use remote's mktemp to create temp dir on remote host#395
Merged
Conversation
This is to protect against the situation where the backup host may have a different default $TMPDIR settings vs the backup host, for example macOS uses /var/folders whilst Linux uses /tmp.
snh
approved these changes
Apr 25, 2018
Merged
dooleydevin
pushed a commit
that referenced
this pull request
Jul 19, 2023
…/boxofyellow/2023_07/Issue1054_0 Backport 393 for 3.9: Init array to Fix https://github.com/github/backup-utils/issues/1054
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, when we create the temporary directory on the remote GitHub Enterprise host during a backup or restore, we create it using the path determined by running
mktempon the backup host.For the most part this works, however it doesn't work when the backup host uses a different OS with a different default
$TMPDIR, like macOS which uses/var/folders.This PR addresses this by using
mkdiron the GitHub Enterprise appliance to create the tempdir there./cc @jatoben