Remove check for git from ghe-ssh#393
Merged
Merged
Conversation
This introduced a bug, as the && isn't interpreted as part of the ||, so GHE_DISABLE_SSH_MUX was always being set to true. As git is listed as part of our requirements, and is being used in more and more places in the backup utilities, it should no-longer be optional.
lildude
approved these changes
Apr 24, 2018
lildude
left a comment
lildude
left a comment
Member
There was a problem hiding this comment.
LGTM.
Git has been a documented requirement for nearly two years.
Merged
dooleydevin
pushed a commit
that referenced
this pull request
Jul 19, 2023
dooleydevin
pushed a commit
that referenced
this pull request
Jul 21, 2023
pluehne
pushed a commit
to pluehne/backup-utils
that referenced
this pull request
Aug 8, 2023
…ssue1054_0 Init array to Fix https://github.com/github/backup-utils/issues/1054
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in #362 and #378 introduced a bug that effectively disabled SSH multiplexing in all cases.
The
&&isn't interpreted as part of the||, soGHE_DISABLE_SSH_MUXwas always being set to true. This can be demonstrated with the following example:As
gitis listed as part of our requirements, and is being used in more and more places in the backup utilities, it should no-longer be considered optional./cc @github/backup-utils @djdefi