Switch back to optimised backup route calculation#392
Merged
Conversation
snh
approved these changes
Apr 24, 2018
snh
suggested changes
Apr 24, 2018
| @@ -64,6 +64,8 @@ user="${host%@*}" | |||
| hostnames=$host | |||
| ssh_config_file_opt= | |||
| tempdir=$(mktemp -d -t backup-utils-restore-XXXXXX) | |||
Member
There was a problem hiding this comment.
The tempdir needs to be created on the remote appliance too, as per https://github.com/github/backup-utils/blob/legacy/share/github-backup-utils/ghe-backup-alambic-cluster-ng#L40.
| @@ -37,6 +37,8 @@ user="${host%@*}" | |||
| hostnames=$host | |||
| ssh_config_file_opt= | |||
| tempdir=$(mktemp -d -t backup-utils-restore-XXXXXX) | |||
Member
There was a problem hiding this comment.
As mentioned, the tempdir needs to be created on the remote appliance too, as per https://github.com/github/backup-utils/blob/legacy/share/github-backup-utils/ghe-backup-alambic-cluster-ng#L40.
snh
approved these changes
Apr 24, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with the restore routes, I inadvertently switched to a sub-optimal route calculation method in #375.
This PR switches back to the optimised backup routes calculation method as #389 did for the restore routes.