Check filesystem supports hardlinks#388
Merged
Merged
Conversation
lildude
changed the title
dbussink
reviewed
Apr 4, 2018
| if ln incomplete test_link >/dev/null 2>&1; then | ||
| rm -f test_link | ||
| else | ||
| echo "Error: the filesystem containing $GHE_DATA_DIR does not support hard links." 1>&2 |
Contributor
There was a problem hiding this comment.
@lildude Should this also explain why we need hard links?
Merged
pluehne
pushed a commit
to pluehne/backup-utils
that referenced
this pull request
Aug 8, 2023
Add bc to requirements
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As backup-utils uses rsync's hardlinking functionality for efficient backup storage, we should really be checking and enforcing this requirement. This PR introduces an early check on the filesystem and exits with an error.
Fixes https://github.com/github/backup-utils/issues/98 - though we don't use the method that caused that problem anymore but we do still use hardlinks.