Allow the restoration of configuration to Cluster#347
Merged
Conversation
If the instance is a cluster, then it will be configured and the earlier check for /etc/github/configured will have set instance_configured to true.
rubiojr
approved these changes
Oct 25, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent introduction of SSH multiplexing support removed the last remaining roadblock to enabling the optional restoration of appliance configuration settings for customers running GitHub Enterprise Cluster.
This PR allows the
-cflag to be used withghe-restorewhen restoring to a Cluster, enabling the restoration ofgithub.conf, which includes settings such as the instance hostname, SSL certificate and authentication options./cc @github/backup-utils for review