Skip to content

Include the user data directory in the benchmark name#311

Merged
snh merged 3 commits into
masterfrom
snh/restore-userdata-benchmark
Jun 5, 2017
Merged

Include the user data directory in the benchmark name#311
snh merged 3 commits into
masterfrom
snh/restore-userdata-benchmark

Conversation

@snh

@snh snh commented Jun 2, 2017

Copy link
Copy Markdown
Member

This was added to the backup side some time ago in 79a1299, but was missed on the restore side:

ghe-backup-store-version took 2s
ghe-import-mysql took 4s
ghe-import-redis took 2s
ghe-restore-repositories-rsync took 3s
ghe-restore-userdata took 3s
ghe-restore-pages-rsync took 3s
ghe-restore-userdata took 3s
ghe-restore-userdata took 3s
ghe-restore-userdata took 3s
ghe-restore-userdata took 0s
ghe-restore-userdata took 2s
ghe-restore-es-rsync took 27s

Adding this will allow us to identify which user data directory a particular benchmark relates to.

/cc @github/backup-utils for review

@snh snh added the bug label Jun 2, 2017
@snh snh requested a review from rubiojr June 2, 2017 15:26
fi

bm_end "$(basename $0)"
bm_start "$(basename $0) - $1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be bm_end here.

@snh snh requested a review from dbussink June 2, 2017 15:36
@snh snh merged commit f2b832d into master Jun 5, 2017
@snh snh deleted the snh/restore-userdata-benchmark branch June 5, 2017 11:30
@snh snh mentioned this pull request Jun 7, 2017
jeluhu pushed a commit that referenced this pull request Jun 12, 2023
Adding check to add trusted sender if supported
@jeluhu jeluhu mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants